Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nmf bugfix #2466

Merged
merged 2 commits into from
May 4, 2019
Merged

Nmf bugfix #2466

merged 2 commits into from
May 4, 2019

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Apr 28, 2019

The logging bugs are blocking our gensim feedstock release on conda.

The divide-by-zero doesn't cause any test failures, but we should fix it anyway.

@mpenkov mpenkov added the bugfix label Apr 28, 2019
@mpenkov mpenkov self-assigned this Apr 28, 2019
@piskvorky
Copy link
Owner

CC @anotherbugmaster.

@mpenkov
Copy link
Collaborator Author

mpenkov commented May 4, 2019

I'm gonna go ahead and merge this in the interest of time.

@mpenkov mpenkov merged commit 20ccabd into piskvorky:develop May 4, 2019
@mpenkov mpenkov deleted the nmf-bugfix branch May 4, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anotherbugmaster anotherbugmaster Awaiting requested review from anotherbugmaster

Assignees

@mpenkov mpenkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpenkov @piskvorky